source: npl/system/netkit-ftp/patches/01-netkit-ftp-0.17-pre20000412.pasv-security.patch @ d849d83

netkit-ftp-0.17-pre20000412

@@ -62 +62 @@
 Use passive mode for data transfers. Allows use of ftp in environments
 where a firewall prevents connections from the outside world back to
 the client machine. Requires that the ftp server support the PASV
-command. This is the default if invoked as
-.Nm pftp.
+command. This is the default now for
+.Nm all
+clients (ftp and pftp) due to security concerns using the PORT transfer mode.
+The flag is kept for compatibility only and has no effect anymore.
 .It Fl i
 Turns off interactive prompting during multiple file transfers.
 .It Fl n

netkit-ftp-0.17-pre20000412

@@ -883 +883 @@
         }
         if (fstat(fileno(fout), &st) < 0 || st.st_blksize == 0)
                 st.st_blksize = BUFSIZ;
-        if (st.st_blksize > bufsize) {
+        if ((unsigned)st.st_blksize > bufsize) {
                 if (buf)
                         (void) free(buf);
                 buf = malloc((unsigned)st.st_blksize);

netkit-ftp-0.17-pre20000412

@@ -87 +87 @@
 usage(void)
 {
         printf("\n\tUsage: { ftp | pftp } [-pinegvtd] [hostname]\n");
-        printf("\t   -p: enable passive mode (default for pftp)\n");
+        printf("\t   -p: enable passive mode (default for ftp and pftp)\n");
         printf("\t   -i: turn off prompting during mget\n");
         printf("\t   -n: inhibit auto-login\n");
         printf("\t   -e: disable readline support, if present\n");
@@ -118 +118 @@
         doglob = 1;
         interactive = 1;
         autologin = 1;
-        passivemode = 0;
+        passivemode = 1;
 
         cp = strrchr(argv[0], '/');
         cp = (cp == NULL) ? argv[0] : cp+1;